Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Manual Backport 2.x][Console] Add support for JSON with long numerals (#4562) #4967

Merged
merged 1 commit into from
Sep 7, 2023
Merged

[Manual Backport 2.x][Console] Add support for JSON with long numerals (#4562) #4967

merged 1 commit into from
Sep 7, 2023

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Sep 7, 2023 •
edited
Loading

Backport of #4562

@AMoo-Miki @kavilla
[Console] Add support for JSON with long numerals (opensearch-project…
3dff74a 
…#4562)

Also:
* Add support for parsing and stringifying JSON with long numerals into `@osd/std`
* Upgrade to `@opensearch/[email protected]` which supports long numerals
* Add support for long numerals to `http/fetch`

Signed-off-by: Miki <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
@kavilla kavilla changed the title [Console] Add support for JSON with long numerals (#4562) [Manual Backport 2.x][Console] Add support for JSON with long numerals (#4562) Sep 7, 2023
@codecov
Copy link

codecov bot commented Sep 7, 2023 •
edited
Loading

Codecov Report

Merging #4967 (3dff74a) into 2.x (d1400d6) will increase coverage by 0.06%.
The diff coverage is 92.03%.

@@            Coverage Diff             @@
##              2.x    #4967      +/-   ##
==========================================
+ Coverage   66.44%   66.50%   +0.06%     
==========================================
  Files        3399     3400       +1     
  Lines       64881    64981     +100     
  Branches    10360    10385      +25     
==========================================
+ Hits        43107    43217     +110     
+ Misses      19215    19203      -12     
- Partials     2559     2561       +2
Flag Coverage Δ
Linux_1 34.82% <15.46%> (-0.05%) ⬇️
Linux_2 55.34% <92.00%> (+0.14%) ⬆️
Linux_3 44.47% <66.37%> (+0.22%) ⬆️
Linux_4 35.02% <26.47%> (-0.03%) ⬇️
Windows_1 34.83% <15.46%> (-0.05%) ⬇️
Windows_2 55.30% <92.00%> (+0.15%) ⬆️
Windows_3 44.48% <66.37%> (+0.23%) ⬆️
Windows_4 35.02% <26.47%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/core/server/opensearch/client/mocks.ts 98.21% <ø> (ø)
...lugins/console/public/lib/opensearch/opensearch.ts 75.00% <ø> (ø)
src/plugins/console/public/services/storage.ts 0.00% <0.00%> (ø)
.../server/routes/api/console/proxy/create_handler.ts 67.39% <40.00%> (-2.38%) ⬇️
packages/osd-std/src/json.ts 95.74% <95.74%> (ø)
packages/osd-std/src/index.ts 100.00% <100.00%> (ø)
src/core/public/http/fetch.ts 96.05% <100.00%> (ø)
...rc/core/server/opensearch/client/cluster_client.ts 85.71% <100.00%> (+1.50%) ⬆️
...equest_to_opensearch/send_request_to_opensearch.ts 70.49% <100.00%> (ø)
src/plugins/console/public/lib/utils/index.ts 86.04% <100.00%> (+27.90%) ⬆️
... and 1 more

... and 1 file with indirect coverage changes

📢 Have feedback on the report? Share it here.

@joshuarrrr joshuarrrr marked this pull request as ready for review September 7, 2023 18:58
@ashwin-pc ashwin-pc merged commit e69d38d into opensearch-project:2.x Sep 7, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 7, 2023
@github-actions @AMoo-Miki
[Console] Add support for JSON with long numerals (#4562) (#4967)
fd4ce6a 
Also:
* Add support for parsing and stringifying JSON with long numerals into `@osd/std`
* Upgrade to `@opensearch/[email protected]` which supports long numerals
* Add support for long numerals to `http/fetch`

Signed-off-by: Miki <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Co-authored-by: Miki <[email protected]>
(cherry picked from commit e69d38d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 7, 2023
Merged
joshuarrrr pushed a commit that referenced this pull request Sep 8, 2023
@opensearch-trigger-bot @github-actions @AMoo-Miki
[Console] Add support for JSON with long numerals (#4562) (#4967) (#4973
e3cebe7 
)

Also:
* Add support for parsing and stringifying JSON with long numerals into `@osd/std`
* Upgrade to `@opensearch/[email protected]` which supports long numerals
* Add support for long numerals to `http/fetch`




(cherry picked from commit e69d38d)

Signed-off-by: Miki <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Miki <[email protected]>
kavilla added a commit to kavilla/OpenSearch-Dashboards-1 that referenced this pull request Sep 8, 2023
@kavilla
Revert "[Console] Add support for JSON with long numerals (opensearch…
9e7d64f 
…-project#4562) (opensearch-project#4967) (opensearch-project#4973)"

This reverts commit e3cebe7.

Signed-off-by: Kawika Avilla <[email protected]>
kavilla added a commit that referenced this pull request Sep 8, 2023
@kavilla
Revert "[Console] Add support for JSON with long numerals (#4562) (#4967
b75edfa 
) (#4973)" (#4977)

This reverts commit e3cebe7.

Signed-off-by: Kawika Avilla <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 8, 2023
@github-actions
Revert "[Console] Add support for JSON with long numerals (#4562) (#4967
e39671c 
) (#4973)" (#4977)

This reverts commit e3cebe7.

Signed-off-by: Kawika Avilla <[email protected]>
(cherry picked from commit b75edfa)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
manasvinibs pushed a commit that referenced this pull request Sep 11, 2023
@opensearch-trigger-bot @github-actions
Revert "[Console] Add support for JSON with long numerals (#4562) (#4967
2233898 
) (#4973)" (#4977) (#4978)

This reverts commit e3cebe7.


(cherry picked from commit b75edfa)

Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwin-pc ashwin-pc ashwin-pc approved these changes

@joshuarrrr joshuarrrr joshuarrrr approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@seanneumann seanneumann Awaiting requested review from seanneumann

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@kristenTian kristenTian Awaiting requested review from kristenTian

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@BSFishy BSFishy Awaiting requested review from BSFishy

Assignees
No one assigned
Labels
v2.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kavilla @joshuarrrr @ashwin-pc @AMoo-Miki